Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual channel watching and dispute test (Last part of large Virtual Channel PR) #83

Merged
merged 9 commits into from
Jul 8, 2021

Conversation

matthiasgeihs
Copy link
Contributor

@matthiasgeihs matthiasgeihs commented May 21, 2021

After splitting up the Virtual channel PR into several smaller, but still not small, PRs, this should now be the last one of that series. It contains:

  • Virtual channel watching
  • Virtual channel dispute tests

Closes #82

@matthiasgeihs matthiasgeihs added this to the Ganymed milestone May 21, 2021
@matthiasgeihs matthiasgeihs force-pushed the 82-virtual-channels branch 4 times, most recently from f10d622 to 9c316fd Compare May 23, 2021 00:39
@matthiasgeihs matthiasgeihs force-pushed the 82-virtual-channels branch 14 times, most recently from 5005e3f to 30dfd5a Compare June 16, 2021 07:57
client/proposal.go Outdated Show resolved Hide resolved
client/adjudicate.go Outdated Show resolved Hide resolved
@matthiasgeihs matthiasgeihs force-pushed the 82-virtual-channels branch 2 times, most recently from f192508 to 3f17b82 Compare June 18, 2021 09:01
@matthiasgeihs matthiasgeihs force-pushed the 82-virtual-channels branch 2 times, most recently from d57cf7d to 08a965c Compare June 18, 2021 11:56
@matthiasgeihs matthiasgeihs force-pushed the 82-virtual-channels branch 4 times, most recently from 3c254ec to 2af1137 Compare July 7, 2021 07:04
@matthiasgeihs matthiasgeihs marked this pull request as ready for review July 7, 2021 07:07
@matthiasgeihs matthiasgeihs changed the title Virtual channels Virtual channel watching and dispute test (Last part of large Virtual Channel PR) Jul 7, 2021
backend/ethereum/channel/backend.go Show resolved Hide resolved
backend/ethereum/channel/subscription.go Outdated Show resolved Hide resolved
backend/ethereum/channel/subscription.go Show resolved Hide resolved
backend/ethereum/channel/subscription.go Show resolved Hide resolved
backend/ethereum/channel/subscription.go Show resolved Hide resolved
client/adjudicate.go Show resolved Hide resolved
client/adjudicate.go Show resolved Hide resolved
client/virtual_channel_test.go Outdated Show resolved Hide resolved
client/virtual_channel_test.go Outdated Show resolved Hide resolved
client/virtual_channel_test.go Outdated Show resolved Hide resolved
client/test/backend.go Show resolved Hide resolved
client/test/backend.go Show resolved Hide resolved
client/test/backend.go Show resolved Hide resolved
client/virtual_channel_test.go Outdated Show resolved Hide resolved
Preparation for virtual channel watching.

Signed-off-by: Matthias Geihs <[email protected]>
Use logFunder, logAdjudicator instead of DummyFunder, DummyAdjudicator
Reduce size of codebase. Reduce redundant parts.

Merge logFunder and logFunderWithDelay.
Merge logFunder and logAdjudicator into logBackend.
Reduce code complexity. Prepare changes that would require adjudicator logic based on the funder state.

Signed-off-by: Matthias Geihs <[email protected]>
- Register: Emit events for sub-channels, add state and sigs
- Subscribe: Only return events for a given channel.
- Withdraw: Print accumulated outcome.

Also rename to mockBackend because it actually does more than just logging.

Signed-off-by: Matthias Geihs <[email protected]>
Usage before was clunky. The user needed to gather subchannels manually
and to know which function to call. Now the framework does that for the user.

Signed-off-by: Matthias Geihs <[email protected]>
Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now.

@ggwpez ggwpez merged commit 427c954 into hyperledger-labs:dev Jul 8, 2021
@ggwpez ggwpez deleted the 82-virtual-channels branch July 8, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual channels
3 participants